container_manager.cpp 33.7 KB
Newer Older
Swann Perarnau's avatar
Swann Perarnau committed
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277
#include "container_manager.hpp"
#include "common.hpp"
#include <sys/mount.h>
#include <fstream>
#include "utils.hpp"
#include "ilogger.hpp"
#include <ftw.h>
#include <libgen.h>
#include "int_list_parser.hpp"
#include <sys/stat.h>
#include <algorithm>
#include <signal.h>

#define OWNERSHIP_MAP_FINALIZED	"MAP_FINALIZED" //Means that the map is in a sane finalized state
#define OWNERSHIP_MAP_TRANSITIONNING	"MAP_TRANSITIONNING" /*Means that the container manager has
															   not properly finalized yet
															   */

const char* default_cgroup_root = "/sys/fs/cgroup/";

#define CGROUUP_FS	"cgroup_root"

Container_manager::Container_manager(ILogger* logger, 
		Error_behavior error_behavior,
		string cgroup_root):
	_no_separate_service_os(true),
	_error_behavior(error_behavior),
	_service_os_root(NULL),
	_cgroup_root(cgroup_root)
{
	_logger = logger;
	if(_cgroup_root[_cgroup_root.size() - 1] != '/')
		_cgroup_root += '/';

	elevate_privileges();
	init_cgroup_fs();

	_argo_argo_container_root =
		_cgroup_root + "cpuset/" + ARGO_ROOT_CONTAINER_NAME + 
		"/" + ARGO_COMPUTE_CONTAINERS_ROOT_NAME;

	/*Create cgroup roots if not existing yet*/
	struct stat sb;
	if(stat(_argo_argo_container_root.c_str(), &sb) == -1 && 
			errno == ENOENT)
	{
		create_root_cgroups();
		if(!_no_separate_service_os)
			migrate_service_os();
	}
	else
		load_root_cgroups();

	load_existing_containers_as_root();
	apply_ownership_map();
	lower_privileges();
}

void Container_manager::get_cpus_breakdown(vector<int>& all_cpus,
		vector<int>& service_cpus, vector<int>& compute_cpus)
{
	all_cpus.clear();
	service_cpus.clear();
	compute_cpus.clear();

	string str;
	Int_list_parser ilp;
	retrieve_from_file(_cgroup_root + "cpuset/cpuset.cpus", str);
	ilp.convert_to_comprehensive(str, all_cpus);
	compute_cpus.assign(all_cpus.begin(), all_cpus.end());

	return; //Not caring about isolcpus anymore

#if 0
	string cmdline;
	retrieve_from_file("/proc/cmdline", cmdline);
	if(!str_contains(cmdline, "isolcpus"))
	{
		_no_separate_service_os = true;
		compute_cpus.assign(all_cpus.begin(), all_cpus.end());
		return;
	}
	string isolcpus;
	str_extract_after(cmdline, "isolcpus=", isolcpus, true);
	str_extract_before(isolcpus, " ", isolcpus);
	assert(isolcpus != "");
	THROW_ON_BAD_INPUT_IF(isolcpus == "",
			"Ill-formed isolcpus found!");
	ilp.convert_to_comprehensive(isolcpus, compute_cpus);
	THROW_ON_BAD_INPUT_IF(!is_superset<int>(all_cpus, compute_cpus),
			"Isolcpus are not a subset of the online cpus");
	get_complement(all_cpus, compute_cpus, service_cpus);
	THROW_ON_BAD_INPUT_IF(service_cpus.empty(),
			"Attempt to build a ServiceOS with no CPU core");
#endif
}


void Container_manager::get_mems_breakdown(vector<int>& all_mems,
		vector<int>& service_mems, 
		vector<int>& compute_mems)
{
	all_mems.clear();
	service_mems.clear();
	compute_mems.clear();

	string str;
	Int_list_parser ilp;
	retrieve_from_file(_cgroup_root + "cpuset/cpuset.mems", str);
	ilp.convert_to_comprehensive(str, all_mems);
	compute_mems.assign(all_mems.begin(), all_mems.end());

	return;  //ignoring argo_sos_mems for now

#if 0
	string cmdline;
	retrieve_from_file("/proc/cmdline", cmdline);
	if(!str_contains(cmdline, "argo_sos_mems"))
	{
		_no_separate_service_os = true;
		compute_mems.assign(all_mems.begin(), all_mems.end());
		return;
	}

	string sos_mems;
	str_extract_after(cmdline, "argo_sos_mems=", sos_mems, true);
	str_extract_before(sos_mems, " ", sos_mems);
	assert(sos_mems != "");
	THROW_ON_BAD_INPUT_IF(sos_mems == "",
			"Ill-formed argo_sos_mems!");
	ilp.convert_to_comprehensive(sos_mems, service_mems);
	THROW_ON_BAD_INPUT_IF(!is_superset<int>(all_mems, service_mems),
			"argo_sos_mems are not a subset of the existing memory nodes");
	get_complement(all_mems, service_mems, compute_mems);
	THROW_ON_BAD_INPUT_IF(compute_mems.empty(),
			"Attempt to build a NodeOs without any memory node for compute containers");
#endif
}

void Container_manager::init_cgroup_fs()
{
	struct stat buf;
	string cpuset = _cgroup_root + "cpuset/";
	string cpuset_tasks = cpuset + "tasks";
	if(stat(cpuset_tasks.c_str(), &buf) == 0)
		return;	 //we're all good

	int ret = mkdir(_cgroup_root.c_str(), S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
	if(ret && errno != EEXIST)
		throw std::runtime_error(strerror(errno));

	//mount -t tmpfs cgroup_root /sys/fs/cgroup;

	ret = mount("cgroup_root", _cgroup_root.c_str(), "tmpfs", 0 , NULL);
	if(ret && errno != EBUSY)
		throw std::runtime_error(strerror(errno));

	ret = mkdir(cpuset.c_str(), S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
	if(ret && errno != EEXIST)
		throw std::runtime_error(strerror(errno));

	ret = mount("cpuset", cpuset.c_str(), "cgroup", 0, "cpuset");
	if(ret && errno != EBUSY)
		throw std::runtime_error(strerror(errno));
}

/*Scan the filesystem and load the containers*/
void Container_manager::apply_ownership_map()
{
	std::ifstream ownership_map_file_in;
	ownership_map_file_in.open(OWNERSHIP_MAP);
	if(ownership_map_file_in.fail())
	{
		if(_containers.size() != 0)
		{
			logger->log(LOG_TYPE_INFO, 
					string("The ownership map does not exist.\n") +
					string("Root will take ownership of the existing Compute Containers\n")+
					string("and reinitialize the map."));
		}
	}
	else
	{
		string name;
		uid_t owner;
		string map_state;
		ownership_map_file_in>>map_state;
		if(map_state != OWNERSHIP_MAP_FINALIZED)
		{
			ownership_map_file_in.close();
			logger->log(LOG_TYPE_INFO, 
					string("The ownership map is in a potentially corrupted stated.\n") +
					string("Root will take ownership of the existing Compute Containers\n")+
					string("and reinitialize the map."));
		}
		else
		{
			while(!ownership_map_file_in.eof())
			{
				ownership_map_file_in>>name;
				ownership_map_file_in>>owner;

				Argo_container *c = find_by_name(name);
				if(c)
					c->set_owner(owner);
			}
			ownership_map_file_in.close();
		}
	}

	std::ofstream ownership_map_file_out;
	ownership_map_file_out.open(OWNERSHIP_MAP);
	THROW_WITH_ERRNO_IF(ownership_map_file_out.fail(), "WTF");
	ownership_map_file_out<<OWNERSHIP_MAP_TRANSITIONNING<<std::endl;
	ownership_map_file_out.close();
}


void Container_manager::create_root_cgroups()
{
	vector<int> all_cpus;
	vector<int> service_cpus;
	vector<int> compute_cpus;
	vector<int> all_mems;
	vector<int> service_mems;
	vector<int> compute_mems;

	get_cpus_breakdown(all_cpus, service_cpus, compute_cpus);
	get_mems_breakdown(all_mems, service_mems, compute_mems);

	_root = new Argo_container(_cgroup_root + "cpuset",
			ARGO_ROOT_CONTAINER_NAME, 0);
	_root->set_cpu_exclusive(true);
	_root->set_mem_exclusive(true);
	_root->set_load_balancing(true);
	_root->add_cpus(all_cpus);
	_root->add_mems(all_mems);	
	_root->create();
	_root->commit_all();

	_argo_containers_root = new Argo_container(
			_root->get_parent_path() + _root->get_name(), 
			ARGO_COMPUTE_CONTAINERS_ROOT_NAME,
			0);
	_argo_containers_root->set_cpu_exclusive(true);
	_argo_containers_root->set_mem_exclusive(true);
	_argo_containers_root->set_load_balancing(true);
	_argo_containers_root->add_cpus(compute_cpus);
	_argo_containers_root->add_mems(compute_mems);	
	_argo_containers_root->create();
	_argo_containers_root->commit_all();

	_cpu_ownerships.build_from(compute_cpus);
	 _mem_ownerships.build_from(compute_mems);

	if(_no_separate_service_os)
		return;

	_service_os_root = new Argo_container(
			_root->get_parent_path() + _root->get_name(), 
			ARGO_SERVICE_OS_CONTAINER_NAME,
			0);
	_service_os_root->set_cpu_exclusive(true);
	_service_os_root->set_mem_exclusive(true);
	_service_os_root->set_load_balancing(true);
	_service_os_root->add_cpus(service_cpus);
	_service_os_root->add_mems(service_mems);	
	_service_os_root->create();
	_service_os_root->commit_all();

	_sos_cpu_ownerships.build_from(service_cpus);
	_sos_mem_ownerships.build_from(service_mems);
}


void Container_manager::migrate_service_os()
{
Kamil Iskra's avatar
Kamil Iskra committed
278
	int n = system("for t in `cat /sys/fs/cgroup/cpuset/tasks`; do /bin/echo $t > /sys/fs/cgroup/cpuset/argo/service_os/tasks; done 2>/dev/null");
Swann Perarnau's avatar
Swann Perarnau committed
279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377
	return;
	vector<int> sos_tasks;
	retrieve_from_file<int>( _cgroup_root + "cpuset/tasks",
			sos_tasks);
	for(int i=0; i<(int)sos_tasks.size(); i++)
		_service_os_root->add_tasks(sos_tasks);
	_service_os_root->commit_last_changes();
}



vector<string> container_names; //sorry for global ... but can't invest time
//in software engineering neatness now -_-

int gather_container_names(const char *fpath, const struct stat *sb, 
		int typeflag)

{
	if(typeflag == FTW_D)
		container_names.push_back(fpath);
	return 0;
}

void Container_manager::load_root_cgroups()
{
	_root = new Argo_container(_cgroup_root + "cpuset",
			ARGO_ROOT_CONTAINER_NAME, 0);
	_root->reload(false);
	_argo_containers_root = new Argo_container(
			_root->get_parent_path() + _root->get_name(), 
			ARGO_COMPUTE_CONTAINERS_ROOT_NAME,
			0);
	_argo_containers_root->reload(false);

	vector<int> compute_cpus;
	vector<int> compute_mems;

	string sos_cgroup_path = _root->get_parent_path() + 
		_root->get_name() + "/" + ARGO_SERVICE_OS_CONTAINER_NAME;
	struct stat sb;
	if(stat(sos_cgroup_path.c_str(), &sb) == 0)
	{
		_no_separate_service_os = false;
		_service_os_root = new Argo_container(
				_root->get_parent_path() + _root->get_name(),
				ARGO_SERVICE_OS_CONTAINER_NAME, 0);
		//_service_os_root->reload(false);
		_service_os_root->reload();


		vector<int> service_cpus;
		vector<int> service_mems;
		_service_os_root->get_cpus(service_cpus);
		_service_os_root->get_mems(service_mems);
		_sos_cpu_ownerships.build_from(service_cpus);
		_sos_mem_ownerships.build_from(service_mems);

		_argo_containers_root->get_cpus(compute_cpus);
		_argo_containers_root->get_mems(compute_mems);
	}
	else
	{
		_no_separate_service_os = true;

		//Load all resources for potential compute container use then.
		string str;
		Int_list_parser ilp;
		retrieve_from_file(_cgroup_root + "cpuset/cpuset.cpus", str);
		ilp.convert_to_comprehensive(str, compute_cpus);

		retrieve_from_file(_cgroup_root + "cpuset/cpuset.mems", str);
		ilp.convert_to_comprehensive(str, compute_mems);
	}

	_cpu_ownerships.build_from(compute_cpus);
	 _mem_ownerships.build_from(compute_mems);
}

void Container_manager::load_existing_containers_as_root()
{
	container_names.clear();
	char buf[MAX_BUF_SIZE];  //HAZARD: (JZ)
	ftw(_argo_argo_container_root.c_str(), gather_container_names, 10);
	for(int i=0; i<(int)container_names.size(); i++)
	{
		if(container_names[i] == _argo_argo_container_root)
			continue;
		strcpy(buf, container_names[i].c_str());
		string name = basename(buf);
		Argo_container* c = new Argo_container(
				_argo_argo_container_root, name, 0);
		c->reload();
		grant_resources(c);
		_containers.push_back(c);
	}
}


Container_manager::~Container_manager()
Kamil Iskra's avatar
Kamil Iskra committed
378 379 380
#if __cplusplus >= 201103L
    noexcept(false)
#endif
Swann Perarnau's avatar
Swann Perarnau committed
381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456
{
	std::ofstream ownership_map_file;
	ownership_map_file.open(OWNERSHIP_MAP);
	THROW_WITH_ERRNO_IF(ownership_map_file.fail(),
			"Failed to open ownership map");
	ownership_map_file<<OWNERSHIP_MAP_FINALIZED<<std::endl;
	for(int i=0; i<(int)_containers.size(); i++)
	{
		ownership_map_file<<_containers[i]->get_name()<<'\t'
			<<_containers[i]->get_owner()<<std::endl;
		delete _containers[i];
		_containers[i] = NULL;
	}
	ownership_map_file.close();
	if(_argo_containers_root)
		delete _argo_containers_root;
	if(_service_os_root)
		delete _service_os_root;
	if(_root)
		delete _root;
}


Argo_container* Container_manager::find_by_name(const string& name)
{
	for(int i=0; i<(int)_containers.size(); i++)
		if(_containers[i]->get_name() == name)
			return _containers[i];
	return NULL;
}

void Container_manager::grant_resources(Argo_container* cc)
{
	vector<int> v;
	cc->get_mems(v);
	_mem_ownerships.grant(v, cc->has_exclusive_mem());
	cc->get_cpus(v);
	_cpu_ownerships.grant(v, cc->has_exclusive_cpu());
}

void Container_manager::reclaim_resources(Argo_container* cc)
{
	vector<int> v;
	cc->get_mems(v);
	_mem_ownerships.reclaim(v);
	cc->get_cpus(v);
	_cpu_ownerships.reclaim(v);
}

bool Container_manager::is_name_available(const string& name)
{
	for(int i=0; i<(int)_containers.size(); i++)
		if(_containers[i]->get_name() == name)
			return false;
	return true;
}

#define HANDLE_CM_ERROR_IF(cond,cm,msg)\
	do{if((cond)){\
		if(cm->get_error_behaviour() == ON_ERROR_CONTINUE)\
		{(cm)->get_logger()->log(LOG_TYPE_ERROR, (msg));return false;}\
		else THROW_ON_FORBIDDEN_ACTION((msg) + string(". Aborting!"));\
	}}while(0)


bool Container_manager::is_legal_create_command(String_parser& sp)
{
	sp.parse();

	string strval;
	string name;
	bool bval;
	vector<int> intvect;
	if(sp.get_string("name", name))
		HANDLE_CM_ERROR_IF(!is_name_available(name), this, 
				string("Another container already has the name ") + strval);
457 458
	else
		THROW_ON_BAD_INPUT("name is missing");
Swann Perarnau's avatar
Swann Perarnau committed
459

460
	bval = true;
Swann Perarnau's avatar
Swann Perarnau committed
461 462
	sp.get_bool("cpu_exclusive", bval);
	if(sp.get_int_list("cpus", intvect))
463
	{
Swann Perarnau's avatar
Swann Perarnau committed
464 465 466 467
		HANDLE_CM_ERROR_IF(!are_resources_available<int>(_cpu_ownerships,
					intvect, bval), this, 
				string("At least part of the requested CPU cores is unavailable") + 
				(bval? string(" exclusively.") : string(".")));
468 469 470 471
		HANDLE_CM_ERROR_IF(intvect.size() == 0, this, "cpu list is empty");
	}
	else
		THROW_ON_BAD_INPUT("cpu list is missing");
Swann Perarnau's avatar
Swann Perarnau committed
472 473 474 475 476 477 478 479 480 481

	if(sp.get_added_int_list("cpus", intvect))
		HANDLE_CM_ERROR_IF(!are_resources_available<int>(_cpu_ownerships,
					intvect, bval), this, 
				string("At least part of the requested CPU cores is unavailable") + 
				(bval? string(" exclusively.") : string(".")));

	bval = false;
	sp.get_bool("mem_exclusive", bval);
	if(sp.get_int_list("mems", intvect))
482
	{
Swann Perarnau's avatar
Swann Perarnau committed
483 484 485 486
		HANDLE_CM_ERROR_IF(!are_resources_available<int>(_mem_ownerships,
					intvect, bval), this, 
				string("At least part of the requested memory nodes is unavailable") +
				(bval? string(" exclusively.") : string(".")));
487 488 489 490
		HANDLE_CM_ERROR_IF(intvect.size() == 0, this, "memory list is empty");
	}
	else
		THROW_ON_BAD_INPUT("memory list is missing");
Swann Perarnau's avatar
Swann Perarnau committed
491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589

	if(sp.get_added_int_list("mems", intvect))
		HANDLE_CM_ERROR_IF(!are_resources_available<int>(_mem_ownerships,
					intvect, bval), this, 
				string("At least part of the requested memory nodes is unavailable") +
				(bval? string(" exclusively.") : string(".")));

	return true;
}


Argo_container* Container_manager::find_host_of_task(int pid)
{
	for(int i=0; i<(int)_containers.size(); i++)
		if(_containers[i]->has_task(pid))
			return _containers[i];
	return NULL;
}

void Container_manager::show_available_resources(string command)
{
	bool shared = true; 
	vector<int> cpus;
	vector<int>mems;
	String_parser sp(command);
	sp.parse();
	THROW_ON_BAD_INPUT_IF(!(sp.get_nb_keys() == 0 || 
				(sp.get_nb_keys() == 1 && sp.has_key("shared"))),
			"Ill-formed show_available_resource_command");
	sp.get_bool("shared", shared);
	for(int i=0; i<(int)_cpu_ownerships.size(); i++)
	{
		if((shared && _cpu_ownerships[i].can_increment_owners()) ||
				(!shared && _cpu_ownerships[i].can_own_exclusively()))
			cpus.push_back(_cpu_ownerships[i].get_resource());
	}

	for(int i=0; i<(int)_mem_ownerships.size(); i++)
	{
		if((shared && _mem_ownerships[i].can_increment_owners()) ||
				(!shared && _mem_ownerships[i].can_own_exclusively()))
			mems.push_back(_mem_ownerships[i].get_resource());
	}

	string str_cpus, str_mems;

	printf(
			"------------Hardware threads------------\n"
			"%s\n\n"
			"------------Memory nodes------------\n"
			"%s\n\n",
			format_int_list_for_display(cpus, str_cpus).c_str(),
			format_int_list_for_display(mems, str_mems).c_str()
		  );
}

void Container_manager::create_container(string command)
{
	String_parser sp(command);
	if(!is_legal_create_command(sp))
		return;
	Argo_container* cc = new Argo_container(_argo_argo_container_root, sp);
	cc->create();
	cc->commit_all();
	grant_resources(cc);
	_containers.push_back(cc);

	_logger->log(LOG_TYPE_INFO, "Container " + cc->get_name() + " created.");
}

void Container_manager::delete_container(string command)
{
	String_parser sp(command);
	sp.parse();
	THROW_ON_BAD_INPUT_IF(!((sp.get_nb_keys() == 1 && sp.has_key("name"))||
				(sp.get_nb_keys() == 2 && sp.has_key("name") && 
				 sp.has_key("kill_content"))),
			"Ill-formed container deletion command");
	string name;
	sp.get_string("name", name);
	Argo_container *cc = find_by_name(name);
	THROW_ON_ERRONEOUS_ACTION_IF(!cc, "Container " + name + " does not exists");

	bool kill_content = false;
	sp.get_bool("kill_content", kill_content);
	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0 && cc->get_owner() != ruid, 
			"Container " + name + " belongs to another user");
	THROW_ON_FORBIDDEN_ACTION_IF(cc->has_any_task() && !kill_content, 
			"Container " + name + " still hosts processes");
	if(kill_content)
	{
		cc->check_task_ownership(true, true);
		cc->kill_content(false);
	}

	if(kill_content)
		sleep(1);

	cc->remove();
Kamil Iskra's avatar
Kamil Iskra committed
590
	bool deleted = false;
Swann Perarnau's avatar
Swann Perarnau committed
591 592 593 594 595 596 597 598 599 600
	vector<Argo_container*>::iterator it;
	for(it = _containers.begin(); it != _containers.end(); it++)
	{
		if(*it == cc)
		{
			_containers.erase(it);
			reclaim_resources(cc);
			_logger->log(LOG_TYPE_INFO, "Container " + cc->get_name() 
					+ " deleted.");
			delete cc;
Kamil Iskra's avatar
Kamil Iskra committed
601
			deleted = true;
Swann Perarnau's avatar
Swann Perarnau committed
602 603 604
			break;
		}
	}
Kamil Iskra's avatar
Kamil Iskra committed
605
	assert(deleted);
Swann Perarnau's avatar
Swann Perarnau committed
606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696
}

void Container_manager::alter_container(string command)
{
	string name;

	String_parser sp(command);
	sp.parse();
	THROW_ON_BAD_INPUT_IF(sp.get_nb_keys() <= 1 || !sp.has_key("name"),
			"Incomplete container altering command");
	if(sp.get_string("rename", name))
		THROW_ON_FORBIDDEN_ACTION_IF(!is_name_available(name), 
			string("Another container already has the name ") + name);

	sp.get_string("name", name);
	Argo_container *cc = find_by_name(name);

	vector<int> current;
	vector<int> overwrite;
	vector<int> added;
	vector<int> removed;
	vector<int> final_cpu_states;
	vector<int> final_mem_states;
	bool bval = false;

	sp.get_bool("cpu_exclusive", bval);
	cc->get_cpus(current);
	sp.get_int_list("cpus", overwrite);
	sp.get_added_int_list("cpus", added);
	sp.get_removed_int_list("cpus", removed);
	Resource_ownership_set<int> simulated_cpu_ownership_state(_cpu_ownerships);
	simulate_containers_final_resource_state(_cpu_ownerships, current, 
			overwrite, added, removed, bval,
			final_cpu_states,
			simulated_cpu_ownership_state);  //This will throw if any issue

	bool cpus_changed = !overwrite.empty() || !added.empty() ||
		!removed.empty();

	bval = false;
	sp.get_bool("mem_exclusive", bval);
	cc->get_mems(current);
	sp.get_int_list("mems", overwrite);
	sp.get_added_int_list("mems", added);
	sp.get_removed_int_list("mems", removed);
	Resource_ownership_set<int> simulated_mem_ownership_state(_mem_ownerships);
	simulate_containers_final_resource_state(_cpu_ownerships, current, 
			overwrite, added, removed, bval,
			final_mem_states,
			simulated_mem_ownership_state);  //This will throw if any issue

	bool mems_changed = !overwrite.empty() || !added.empty() ||
		!removed.empty();

	_cpu_ownerships = simulated_cpu_ownership_state;
	_mem_ownerships = simulated_mem_ownership_state;

	//Nothing threw. We can alter the container from here on 
	if(sp.get_string("rename", name))
		cc->rename(name);
	if(sp.get_bool("cpu_exclusive", bval))
		cc->set_cpu_exclusive(bval);
	if(sp.get_bool("mem_exclusive", bval))
		cc->set_mem_exclusive(bval);
	if(sp.get_bool("mem_migrate", bval))
		cc->set_mem_migrate(bval);

	if(cpus_changed)
		cc->replace_cpus(final_cpu_states);
	if(mems_changed)
		cc->replace_mems(final_mem_states);

	cc->commit_last_changes();
	_logger->log(LOG_TYPE_INFO, "Container " + cc->get_name() + " altered.");
}

void Container_manager::alter_service_os(string command)
{
	THROW_NOT_IMPLEMENTED_EXCEPTION();  //Fix the TODO below before removing this

	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0,
			"Only root can alter the service_os config.");
#if 0
	THROW_ON_ERRONEOUS_ACTION_IF(!_service_os_root,
			"The node has no service_os");
#else
	if(!_service_os_root)
		return;
#endif
	String_parser sp(command);
	sp.parse();
697 698
	const char* initkeys[] = {"cpus", "+cpus", "-cpus", "mems", "+mems", "-mems", "mem_migrate"};
	vector<string> allowed_keys(initkeys, initkeys + sizeof(initkeys) / sizeof(initkeys[0]));
Swann Perarnau's avatar
Swann Perarnau committed
699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781
	THROW_ON_BAD_INPUT_IF(sp.has_forbidden_keys(allowed_keys), 
			"Invalid service_os alteration command");

	vector<int> current;
	vector<int> overwrite;
	vector<int> added;
	vector<int> removed;
	vector<int> final_cpu_states;
	vector<int> final_mem_states;
	Resource_ownership_set<int> simulated_final_cpu_sos;
	Resource_ownership_set<int> simulated_final_mem_sos;
	Resource_ownership_set<int> simulated_final_cpu_cc;
	Resource_ownership_set<int> simulated_final_mem_cc;

	_service_os_root->get_cpus(current);
	sp.get_int_list("cpus", overwrite);
	sp.get_added_int_list("cpus", added);
	sp.get_removed_int_list("cpus", removed);

	simulate_sos_final_resource_state(_sos_cpu_ownerships,
			_cpu_ownerships, current, overwrite, added, removed,
			final_cpu_states, simulated_final_cpu_sos,
			simulated_final_cpu_cc);

	bool cpus_changed = !overwrite.empty() || !added.empty() ||
		!removed.empty();

	_service_os_root->get_mems(current);
	sp.get_int_list("mems", overwrite);
	sp.get_added_int_list("mems", added);
	sp.get_removed_int_list("mems", removed);

	simulate_sos_final_resource_state(_sos_mem_ownerships,
			_mem_ownerships, current, overwrite, added, removed,
			final_mem_states, simulated_final_mem_sos,
			simulated_final_mem_cc);
	
	bool mems_changed = !overwrite.empty() || !added.empty() ||
		!removed.empty();

	//Nothing threw; we're good!
	
	//TODO: There is a potential conflict here. If a resource is swapped between
	//both _service_os_root and _argo_containers_root, then there will be some transcient
	//exclusivity violation and things will silently fail. Cater to this later on
	if(cpus_changed)
	{
		_service_os_root->replace_cpus(final_cpu_states);
		_cpu_ownerships = simulated_final_cpu_cc;
		_sos_cpu_ownerships = simulated_final_cpu_sos;
		vector<int> cpus;
		_cpu_ownerships.get_resources(cpus);
		_argo_containers_root->replace_cpus(cpus);
	}

	if(mems_changed)
	{
		_service_os_root->replace_mems(final_mem_states);
		_mem_ownerships = simulated_final_mem_cc;
		_sos_mem_ownerships = simulated_final_mem_sos;
		vector<int> mems;
		_mem_ownerships.get_resources(mems);
		_argo_containers_root->replace_mems(mems);
	}

	bool bval;
	if(sp.get_bool("mem_migrate", bval))
		_service_os_root->set_mem_migrate(bval);
	_service_os_root->commit_last_changes();
	_logger->log(LOG_TYPE_INFO, "Service_os altered");

	if(cpus_changed || mems_changed)
		_argo_containers_root->commit_last_changes();
}

void Container_manager::create_service_os(string command)
{
	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0,
			"Only root can create the service_os config.");
	THROW_ON_ERRONEOUS_ACTION_IF(_service_os_root,
			"The node already has a service_os");
	String_parser sp(command);
	sp.parse();
782 783
	const char* initkeys[] = {"cpus", "mems"};
	vector<string> allowed_keys(initkeys, initkeys + sizeof(initkeys) / sizeof(initkeys[0]));
Swann Perarnau's avatar
Swann Perarnau committed
784 785 786 787 788
	THROW_ON_BAD_INPUT_IF(sp.has_forbidden_keys(allowed_keys), 
			"Invalid service_os creation command");


	vector<int> cpus;
789 790 791 792 793 794 795 796 797 798 799
	if(sp.get_int_list("cpus", cpus))
	{
		THROW_ON_FORBIDDEN_ACTION_IF(!are_resources_available<int>(_cpu_ownerships,
					cpus, true),
				string("At least part of the requested CPU cores is unavailable"));
		THROW_ON_FORBIDDEN_ACTION_IF(!_cpu_ownerships.are_unused(cpus),
				"Some of the CPU cores requested are already in use");
		THROW_ON_FORBIDDEN_ACTION_IF(cpus.size() == 0, "cpu list is empty");
	}
	else
		THROW_ON_FORBIDDEN_ACTION("cpu list is missing");
Swann Perarnau's avatar
Swann Perarnau committed
800
	vector<int> mems;
801 802 803 804 805 806 807 808 809 810 811
	if (sp.get_int_list("mems", mems))
	{
		THROW_ON_FORBIDDEN_ACTION_IF(!are_resources_available<int>(_mem_ownerships,
					mems, true),
				string("At least part of the requested memory nodes is unavailable"));
		THROW_ON_FORBIDDEN_ACTION_IF(!_mem_ownerships.are_unused(cpus),
				"Some of the memory nodes requested are already in use");
		THROW_ON_FORBIDDEN_ACTION_IF(mems.size() == 0, "memory list is empty");
	}
	else
		THROW_ON_FORBIDDEN_ACTION("memory list is missing");
Swann Perarnau's avatar
Swann Perarnau committed
812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879
	_cpu_ownerships.transfer_to(cpus, _sos_cpu_ownerships);	
	_mem_ownerships.transfer_to(mems, _sos_mem_ownerships);
	_argo_containers_root->remove_cpus(cpus);
	_argo_containers_root->remove_mems(mems);
	_argo_containers_root->commit_last_changes();
	
	_service_os_root = new Argo_container(
			_root->get_parent_path() + _root->get_name(), 
			ARGO_SERVICE_OS_CONTAINER_NAME,
			0);
	_service_os_root->set_cpu_exclusive(true);
	_service_os_root->set_mem_exclusive(true);
	_service_os_root->set_load_balancing(true);
	_service_os_root->add_cpus(cpus);
	_service_os_root->add_mems(mems);	
	bool bval;
	if(sp.get_bool("mem_migrate", bval))
		_service_os_root->set_mem_migrate(bval);
	_service_os_root->create();
	_service_os_root->commit_all();

	migrate_service_os();
	_logger->log(LOG_TYPE_INFO, "Service_os created");
}

void Container_manager::delete_service_os()
{
	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0,
			"Only root can delete the service_os config.");
#if 0
	THROW_ON_ERRONEOUS_ACTION_IF(!_service_os_root,
			"The node has no service_os");
#else
	if(!_service_os_root)
		return;
#endif

	//First migrate the tasks
	Argo_container very_root(_cgroup_root,
			"cpuset", 0);
	vector<int> tasks;
	_service_os_root->get_tasks(tasks);
	very_root.add_tasks(tasks);
	very_root.commit_last_changes();

	vector<int> cpus;
	vector<int> mems;
	_service_os_root->get_cpus(cpus);
	_service_os_root->get_mems(mems);
	_service_os_root->remove();

	_sos_cpu_ownerships.transfer_to(cpus, _cpu_ownerships);
	_sos_mem_ownerships.transfer_to(mems, _mem_ownerships);
	_argo_containers_root->add_cpus(cpus);
	_argo_containers_root->add_mems(mems);
	_argo_containers_root->commit_last_changes();
	_logger->log(LOG_TYPE_INFO, "Service_os deleted");
}

void Container_manager::reset()
{
	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0,
			"Only root can reset the node.");
	if(_service_os_root)
		delete_service_os();
	clean_config("");
	
	/*Temporary ugly brutal hack [JZ] (\_/)*/
Kamil Iskra's avatar
Kamil Iskra committed
880
	int n = system("rmdir /sys/fs/cgroup/cpuset/argo/argo_containers/ && rmdir /sys/fs/cgroup/cpuset/argo/");
Swann Perarnau's avatar
Swann Perarnau committed
881 882 883 884 885 886 887 888 889 890 891 892
}

void Container_manager::attach_to_container(string command)
{
	String_parser sp(command);
	sp.parse();
	THROW_ON_BAD_INPUT_IF(!sp.has_key("name") || !sp.has_key("pids") ||
			sp.get_int_list_size("pids") < 1,
			"Bad attach process command");
	string name;
	sp.get_string("name", name);
	Argo_container *cc = find_by_name(name);
Kamil Iskra's avatar
Kamil Iskra committed
893
	THROW_ON_ERRONEOUS_ACTION_IF(!cc, "Container " + name + " does not exists");
Swann Perarnau's avatar
Swann Perarnau committed
894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947

	vector<int> tasks;
	sp.get_int_list("pids", tasks);
	THROW_ON_ERRONEOUS_ACTION_IF(cc->has_any_of_these_tasks(tasks), 
			"At least one of the processes is already hosted in " + name + ".");

#ifndef LOOSE_DEMO
	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0 && (ruid != cc->get_owner()),
			"Can't attach to container " + cc->get_name() + 
			" because it belongs to another user! Alternatively, the action can be performed as root");
#endif //LOOSE_DEMO

	for(vector<Argo_container*>::iterator it = _containers.begin();
			it != _containers.end(); it++)
	{
		if((*it)->get_name() == cc->get_name())
			continue;

		THROW_ON_FORBIDDEN_ACTION_IF((*it)->has_any_of_these_tasks(tasks),
				"At least one of the tasks is already attached to a container. Please use --migrate_to_container instead  ");
	}

	if(ruid != 0)
	{
		uid_t uid;
		for(int i=0; i<(int)tasks.size(); i++)
		{
			uid = get_task_owner(tasks[i]);
			if(uid != UID_INVALID && uid != ruid)
			{
				std::ostringstream ss;
				ss<<"The task of pid "<<tasks[i]<<" belongs to another user.";
				THROW_ON_FORBIDDEN_ACTION(ss.str());
			}
		}
	}

	cc->add_tasks(tasks);
	cc->commit_last_changes();
}

void Container_manager::detach_from_container(string command)
{
	logger->log(LOG_TYPE_INFO, "Not implemented yet");
	return;

	String_parser sp(command);
	sp.parse();
	THROW_ON_BAD_INPUT_IF(!sp.has_key("name") || !sp.has_key("pids") ||
			sp.get_int_list_size("pids") < 1,
			"Bad detach process command");
	string name;
	sp.get_string("name", name);
	Argo_container *cc = find_by_name(name);
Kamil Iskra's avatar
Kamil Iskra committed
948
	THROW_ON_ERRONEOUS_ACTION_IF(!cc, "Container " + name + " does not exists");
Swann Perarnau's avatar
Swann Perarnau committed
949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972

	vector<int> tasks;
	sp.get_int_list("pids", tasks);
	THROW_ON_ERRONEOUS_ACTION_IF(!cc->has_all_these_tasks(tasks), 
			"At least one of the processes is not or no longer hosted in  " + name + ".");

	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0 && (ruid != cc->get_owner()),
			"Can't detach from container " + cc->get_name() + 
			" because it belongs to another user! Alternatively, the action can be performed as root");

	cc->remove_tasks(tasks);
	commit_in_file(_cgroup_root + "cpuset/tasks", tasks);
}

void Container_manager::migrate_to_container(string command)
{
	String_parser sp(command);
	sp.parse();
	THROW_ON_BAD_INPUT_IF(!sp.has_key("name") || !sp.has_key("pids") ||
			sp.get_int_list_size("pids") < 1,
			"Bad migrate process command");
	string name;
	sp.get_string("name", name);
	Argo_container *cc = find_by_name(name);
Kamil Iskra's avatar
Kamil Iskra committed
973
	THROW_ON_ERRONEOUS_ACTION_IF(!cc, "Container " + name + " does not exists");
Swann Perarnau's avatar
Swann Perarnau committed
974 975 976 977 978 979 980 981 982 983 984 985 986 987

	vector<int> tasks;
	sp.get_int_list("pids", tasks);

#if 0
	THROW_ON_ERRONEOUS_ACTION_IF(cc->has_any_of_these_tasks(tasks), 
			"At least one of the processes is already hosted in " + name + ".");
#endif

	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0 && (ruid != cc->get_owner()),
			"Can't migrate to container " + cc->get_name() + 
			" because it belongs to another user! Alternatively, the action can be performed as root");

	std::ostringstream oss;
Kamil Iskra's avatar
Kamil Iskra committed
988
	for(vector<int>::iterator task = tasks.begin(); task != tasks.end(); task++)
Swann Perarnau's avatar
Swann Perarnau committed
989 990
	{
		bool is_task_contained = false;
Kamil Iskra's avatar
Kamil Iskra committed
991 992
		for(vector<Argo_container*>::iterator cont = _containers.begin();
		    cont != _containers.end(); cont++)
Swann Perarnau's avatar
Swann Perarnau committed
993
		{
Kamil Iskra's avatar
Kamil Iskra committed
994
			if((*cont)->has_task(*task))
Swann Perarnau's avatar
Swann Perarnau committed
995 996 997 998 999 1000 1001
			{
				is_task_contained = true;
				break;
			}
		}
		if(!is_task_contained)
		{
Kamil Iskra's avatar
Kamil Iskra committed
1002
			oss<<"Task "<<*task<<" is not in any Argo container; it cannot be migrated";
Swann Perarnau's avatar
Swann Perarnau committed
1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092
			THROW_ON_ERRONEOUS_ACTION(oss.str());
		}
	}

	if(ruid != 0)
	{
		for(vector<Argo_container*>::iterator it = _containers.begin();
				it != _containers.end(); it++)
		{
			if((*it)->get_name() == cc->get_name())
				continue;

			THROW_ON_FORBIDDEN_ACTION_IF((*it)->has_any_of_these_tasks(tasks) &&
					(*it)->get_owner() != ruid,
					string("At least one of the tasks belongs to container ") + 
					(*it)->get_name() +
					string(" which belongs to another user. Please retry as root!"));
		}
	}

	cc->add_tasks(tasks);
	cc->commit_last_changes();
}

bool compare_names(Argo_container* c0, Argo_container* c1)
{
	return c0->get_name() < c1->get_name();
}

void Container_manager::show_config()
{
	if(_no_separate_service_os)
		printf("\nNO SEPARATE SERVICE_OS!\n\n");
	else
	{
		printf("\n======SERVICE_OS======\n");
		_service_os_root->display_resources();
		printf("-  %d tasks\n", _service_os_root->get_nb_tasks());
		printf("======================\n\n");
	}

	vector<Argo_container*> sorted;
	sorted.assign(_containers.begin(), _containers.end());
	std::sort(sorted.begin(), sorted.end(), compare_names);
	for(int i=0; i<(int)sorted.size(); i++)
	{
#ifndef DEBUG
		sorted[i]->reload();
#endif
		sorted[i]->display();
	}
}

void Container_manager::clean_config(string command)
{
	String_parser sp(command);
	sp.parse();
	THROW_ON_BAD_INPUT_IF(!(sp.get_nb_keys() == 0 || 
				(sp.get_nb_keys() == 1 && sp.has_key("kill_content"))),
			"Ill-formed clean_config command");
	bool kill_content = false;
	sp.get_bool("kill_content", kill_content);

	for(int i=0; i<(int)_containers.size(); i++)
	{
		THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0 && (ruid != _containers[i]->get_owner()),
				"At least one of the existing containers belongs to another user. Please retry as root");

		THROW_ON_FORBIDDEN_ACTION_IF(_containers[i]->has_any_task() && !kill_content, 
				string("Config cleaning failed! Container " + 
					_containers[i]->get_name() + " still hosts processes"));

		if(kill_content)
			_containers[i]->check_task_ownership(true, true);
	}

	if(kill_content)
		sleep(1);

	vector<Argo_container*>::iterator it;
	for(it = _containers.begin(); it != _containers.end(); it++)
	{
		if(kill_content)
			(*it)->kill_content(false);
		(*it)->remove();
		delete *it;
	}
	_containers.clear();
	_logger->log(LOG_TYPE_INFO, "Config has been cleaned.");
}
Kamil Iskra's avatar
Kamil Iskra committed
1093 1094 1095 1096 1097 1098

void Container_manager::exec(string command)
{
	String_parser sp(command);
	sp.parse();

1099 1100
	THROW_ON_BAD_INPUT_IF(!sp.has_key("name") || !sp.has_key("argv") ||
			      !sp.has_key("env"), "Bad exec command");
Kamil Iskra's avatar
Kamil Iskra committed
1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
	string name;
	sp.get_string("name", name);

	Argo_container *cc = find_by_name(name);

	THROW_ON_ERRONEOUS_ACTION_IF(!cc, "Container " + name + " does not exists");

	THROW_ON_FORBIDDEN_ACTION_IF(ruid != 0 && (ruid != cc->get_owner()),
			"Can't execute in container " + cc->get_name() +
			" because it belongs to another user! Alternatively, the action can be performed as root");

	string argv;
	sp.get_string("argv", argv);

	if (argv[0] == '\'') /* Strip ' from both ends.  */
	    argv = argv.substr(1, argv.size() - 2);

	vector<string> argvs;
	split(argv, ' ', argvs);

	/* Remove a single layer of backslashes.  */
	for (vector<string>::iterator i = argvs.begin(); i != argvs.end(); ++i)
1123
	    for (string::iterator j = i->begin(); j != i->end(); ++j)
Kamil Iskra's avatar
Kamil Iskra committed
1124 1125 1126
		if (*j == '\\')
		    i->erase(j);

1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
	string env;
	sp.get_string("env", env);

	if (env[0] == '\'') /* Strip ' from both ends.  */
	    env = env.substr(1, env.size() - 2);

	vector<string> envs;
	split(env, ' ', envs);

	/* Remove a single layer of backslashes.  */
	for (vector<string>::iterator i = envs.begin(); i != envs.end(); ++i)
	    for (string::iterator j = i->begin(); j != i->end(); ++j)
		if (*j == '\\')
		    i->erase(j);

Kamil Iskra's avatar
Kamil Iskra committed
1142 1143 1144 1145 1146 1147 1148
	vector<int> tasks(1, getpid());
	cc->add_tasks(tasks);
	cc->commit_last_changes();

	std::ostringstream ss;
	ss << "About to execute";

1149
	/* We use global allocators so that _exec_* survive after
Kamil Iskra's avatar
Kamil Iskra committed
1150 1151 1152 1153 1154 1155 1156 1157 1158 1159
	   the container manager is destroyed.  */
	_exec_argv = new char*[argvs.size() + 1];
	for (int i = 0; i < argvs.size(); i++)
	{
	    _exec_argv[i] = new char[argvs[i].size() + 1];
	    strcpy(_exec_argv[i], argvs[i].c_str());
	    ss << " '" << argvs[i] << "'";
	}
	_exec_argv[argvs.size()] = NULL;

1160 1161 1162 1163 1164 1165 1166 1167 1168 1169
	ss << " [environment]";
	_exec_env = new char*[envs.size() + 1];
	for (int i = 0; i < envs.size(); i++)
	{
	    _exec_env[i] = new char[envs[i].size() + 1];
	    strcpy(_exec_env[i], envs[i].c_str());
	    ss << " '" << envs[i] << "'";
	}
	_exec_env[envs.size()] = NULL;

Kamil Iskra's avatar
Kamil Iskra committed
1170 1171
	_logger->log(LOG_TYPE_INFO, ss.str());
}