GitLab

Remove support for direct pointers in a DMA request, with the goal to
remove va_args in the entire DMA API soon. As scratchs still work with
pointers, also modify scratchs to convert tiles in layouts.

This reverts commit 04315e6e.

Not needed since vector doesn't contain the actual inner type.

Various fixes related to dma API, missing validation on arguments,
pthread management and so on.

The bitmap tests were slowing down the entire pipeline, while at the
same time missing important checks on the inputs. This version is a bit
more exhaustive, while also speeding up the test by only checking the
corner-cases (first bits, last bits, partial ranges, overlapping
ranges).

Since vector resize can cause pointers into the vector to become
invalid, this patch introduces a level of indirection for DMAs and
Scratchs, using uuid on the user-side of a request to index into the
request vector.

We need the vector type used for all our "command queues" to be able to
maintain pointers to the inner data structure across reallocs of the
vector itself. The resulting change just uses independent callocs for
each pointer to a data element.

Refactor the DMA API to work on layouts internally. The resulting code
ends up simpler for most cases, as long as we add a generic copy
function.

One things missing:
- a good API to expose the collection of copy functions we have.

One question not solved:
- should the DMA ask for a copy function on each operation ?

Layout are a bit more complex as they contain extra arrays at the end
of the struct, so new macros are required.

Add a set of macros to help us deal with several mallocs back-to-back in
creators, while ensuring that pointers stay aligned properly.

See #45 for details. Related to the !68 cleanup.

Nicolas Denoyelle authored Aug 06, 2019 and Swann Perarnau committed Aug 06, 2019

Add new building block describing how data
is organized in memory.

Removes static allocations of all objects from the library.
While this will make our code less compact in theory,
this part of the API is too confusing for new users.

Less than perfect types for the most part, plus a few unused variables.

Caught by a fun warning about weird function-pointer-to-int conversion.

MAP_ANONYMOUS is only visible in _GNU_SOURCE code. Ensure the config
header is included first so that this symbol appears.

Also create the basic page structure, including importing the doxygen
API documentation through breathe.

Also fix some doxygen config, as doxygen wasn't generating scratchpad
info, and the dma implementation groups had a different name that the
structs.

Implement #31 for vector.
Improve error management.
Checkpatch vector.

Implement #31 for tiling.
Improve error management.
Checkpatch tiling.

Implement #31 for scratch.
Improve error management.
Checkpatch scratch.

Implement #31 for dma.
Improve error management.
Checkpatch dma

Implement #31 for bitmap.
Extra init/fini function for API consistency, but not needed.
Checkpatch another header.

Convert area/area_linux to new error handler.
Implement #31 for area.
Checkpatch area

Note that area_linux is still using a dynamic data structure no matter
what: a bitmask to the set of authorized nodes. The conversion to
aml_bitmap wouldn't help as there's no default value available for all
nodes on that type (similar to numa_all_nodes_ptr).

In POSIX land, error codes are positive integers, returned by functions
as a negative value, but assigned to errno as a positive value.

Use that chance to checkpatch the files.

The source repo has been reorganized, but the repoquality checks were
not updated. Also make sure that style checks happen early, to fail the
CI quickly.

Fixes #16.

Same as the rest.

We're starting to agree on one main header for all the generic APIs of
building blocks, struct definitions included, and one header per
specific implementation.

Improve the spelling while we're at it.

Poorly supported feature that doesn't play well with the rest of the
library and limits what we can do in the future.

Use m4 to define autoconf-level version variables, following the naming
scheme of semver.org

To make use of these variables in the headers and sources, a
generated-header is added in aml/utils/version.h

Also add a simple test for that part of the lib.

The overall strategy for now is to split the implementations into
distinct headers, but keep the generic APIs inside the main aml.h

Related to #27

The overall strategy for now is to split the implementations into
distinct headers, but keep the generic APIs inside the main aml.h

Related to #27

Nicolas Denoyelle authored Mar 14, 2019 and Swann Perarnau committed Mar 14, 2019

While the current bitmask management is heavily inspired by libnuma, it is not
as easy to use has the libnuma API. This patch is an attempt to refactor
to code towards something cleaner.

Nicolas Denoyelle authored Mar 12, 2019 and Swann Perarnau committed Mar 13, 2019

- create one directory per building block in src and include
- keep one directory for tests, \
  otherwise automake make them "test suites"
- move to AC_OPENMP, which is from autoconf 2.62 (2008)