GitLab

Since vector resize can cause pointers into the vector to become
invalid, this patch introduces a level of indirection for DMAs and
Scratchs, using uuid on the user-side of a request to index into the
request vector.

We need the vector type used for all our "command queues" to be able to
maintain pointers to the inner data structure across reallocs of the
vector itself. The resulting change just uses independent callocs for
each pointer to a data element.

[refactor] redesign DMAs to support layouts

Closes #46

See merge request !73

Refactor the DMA API to work on layouts internally. The resulting code
ends up simpler for most cases, as long as we add a generic copy
function.

One things missing:
- a good API to expose the collection of copy functions we have.

One question not solved:
- should the DMA ask for a copy function on each operation ?

Add inner-malloc utils

Closes #45

See merge request !69

Layout are a bit more complex as they contain extra arrays at the end
of the struct, so new macros are required.

Use the newly added INNER_MALLOC for all the relevant creators.

Add a set of macros to help us deal with several mallocs back-to-back in
creators, while ensuring that pointers stay aligned properly.

See #45 for details. Related to the !68 cleanup.

AML Layouts

See merge request !70

Nicolas Denoyelle authored Aug 06, 2019 and Swann Perarnau committed Aug 06, 2019

Add new building block describing how data
is organized in memory.

Remove static allocs

Closes #37

See merge request !68

Removes static allocations of all objects from the library.
While this will make our code less compact in theory,
this part of the API is too confusing for new users.

Make out-of-tree build work

See merge request !63

ndenoyelle authored Jun 26, 2019 and Swann Perarnau committed Jul 02, 2019

Adapted to the new master from a patch sent by @cfoyer



    When building out of tree as the, make sure that target refer to
    relative paths.

    This commit also clean-up the usage of the flags and defines
    a per-target definition of flags (can be changed for a
    AM_CPPFLAGS if the global definition is good enough).
Signed-off-by: Clement Foyer <cfoyer@cray.com>

Also adds Clement to the authors list.

ndenoyelle authored Jun 26, 2019 and Swann Perarnau committed Jul 02, 2019

Out-of-tree builds are popular when one doesn't want to pollute the
source tree with objects. It also helps debug build setup issues.

ndenoyelle authored Jun 26, 2019 and Swann Perarnau committed Jul 02, 2019

- hide echo command but not echo itself
- fix dist-hook useless if not building doc and creating error on make
  dist

Better flags for CI

See merge request !65

Sometimes the CI fails on configure, make sure we capture the log file
for those cases.

Recursive makefiles do not propagation automake flags (AM_CFLAGS),
making the proper configuration of the whole build chain more complex
than it needs to be. This patch goes back to a single makefile.am in
src, simplifying the build quite a bit.

One more silent error. ax_pthreads will fail on -Werror, so we still
need to fix that.

Still fails, some issues in configure.ac/Makefile.am

Note that this still fails on make check, some problem with
CPPFLAGS/LDFLAGS

There's an actual bugfix on tilings in there, as well as extra type
mismatches.

Less than perfect types for the most part, plus a few unused variables.

Some string.h definitions only appear if _GNU_SOURCE is defined, which
is done for us in config.h. As usual, only include this in the .c files,
and first in the header.

Vector implementation was lacking some rigor. Note that it is a bit
tricky to use an int for the `na` element and size_t for an index.

Caught by a fun warning about weird function-pointer-to-int conversion.

We've recently received messages indicating that some compiler
environments out there would choke on some of the code. Let's try to
make the code as C99 compliant and as reliable as possible by activating
more warnings and breaking the CI on it.

autoconf macros fail on -Werror -Wall because of unused variable
warnings, so we deactivate those.

Improve checkpatch workflow, fix the resulting errors

Closes #43

See merge request !67

Nicolas Denoyelle authored Jun 28, 2019 and Swann Perarnau committed Jun 28, 2019

Pretty straightforward.
Close #43.

Generate the list of source files automatically, to ensure that we don't
miss something.

Improve configure script, header includes

See merge request !64

MAP_ANONYMOUS is only visible in _GNU_SOURCE code. Ensure the config
header is included first so that this symbol appears.

Our code relies on _GNU_SOURCE in a couple of places, so make sure we
call it. Take this opportunity to reorder and clean up the configure.ac
config a bit.

[doc] fix contributing link

Closes #38

See merge request !62

Closes #38.

Also adds a caption to the toctree.

fix doxygen version on readthedocs

See merge request !60

fix CI

See merge request !59