Area cuda

See merge request !76

Nicolas Denoyelle authored Aug 23, 2019 and Swann Perarnau committed Aug 23, 2019

New area allow to allocate data on cuda devices.
Allocation optionally include the ability to map
host memory on device memory. See cuda area
documentation.

Includes libtool helper to link cuda device object files
with the remaining of the library.

An additional error code has been added to aml errors for handling busy cuda devices
Also, all CI stages as been set not to run on branches name starting with wip.

Remove dma va args

Closes #49

See merge request !77

Now that only one type of request is allowed (layouts), remove va_args
for the DMA API, making it significantly cleaner.

Fix #49.

Remove support for direct pointers in a DMA request, with the goal to
remove va_args in the entire DMA API soon. As scratchs still work with
pointers, also modify scratchs to convert tiles in layouts.

This reverts commit 04315e6e.

Not needed since vector doesn't contain the actual inner type.

Improve speed and exhaustiveness of the unit tests.

See merge request !74

Various fixes related to dma API, missing validation on arguments,
pthread management and so on.

Unit tests were missing a few corner cases on dense_create. In
particular, there was a bug in the handling of the NULL pitch.

The bitmap tests were slowing down the entire pipeline, while at the
same time missing important checks on the inputs. This version is a bit
more exhaustive, while also speeding up the test by only checking the
corner-cases (first bits, last bits, partial ranges, overlapping
ranges).

Fix vector resize issue on async requests

Closes #48

See merge request !75

Since vector resize can cause pointers into the vector to become
invalid, this patch introduces a level of indirection for DMAs and
Scratchs, using uuid on the user-side of a request to index into the
request vector.

We need the vector type used for all our "command queues" to be able to
maintain pointers to the inner data structure across reallocs of the
vector itself. The resulting change just uses independent callocs for
each pointer to a data element.

[refactor] redesign DMAs to support layouts

Closes #46

See merge request !73

Refactor the DMA API to work on layouts internally. The resulting code
ends up simpler for most cases, as long as we add a generic copy
function.

One things missing:
- a good API to expose the collection of copy functions we have.

One question not solved:
- should the DMA ask for a copy function on each operation ?

Add inner-malloc utils

Closes #45

See merge request !69

Layout are a bit more complex as they contain extra arrays at the end
of the struct, so new macros are required.

Use the newly added INNER_MALLOC for all the relevant creators.

Add a set of macros to help us deal with several mallocs back-to-back in
creators, while ensuring that pointers stay aligned properly.

See #45 for details. Related to the !68 cleanup.

AML Layouts

See merge request !70

Nicolas Denoyelle authored Aug 06, 2019 and Swann Perarnau committed Aug 06, 2019

Add new building block describing how data
is organized in memory.

Remove static allocs

Closes #37

See merge request !68

Removes static allocations of all objects from the library.
While this will make our code less compact in theory,
this part of the API is too confusing for new users.

Make out-of-tree build work

See merge request !63

ndenoyelle authored Jun 26, 2019 and Swann Perarnau committed Jul 02, 2019

Adapted to the new master from a patch sent by @cfoyer



    When building out of tree as the, make sure that target refer to
    relative paths.

    This commit also clean-up the usage of the flags and defines
    a per-target definition of flags (can be changed for a
    AM_CPPFLAGS if the global definition is good enough).

Signed-off-by: Clement Foyer <cfoyer@cray.com>

Also adds Clement to the authors list.

ndenoyelle authored Jun 26, 2019 and Swann Perarnau committed Jul 02, 2019

Out-of-tree builds are popular when one doesn't want to pollute the
source tree with objects. It also helps debug build setup issues.

ndenoyelle authored Jun 26, 2019 and Swann Perarnau committed Jul 02, 2019

- hide echo command but not echo itself
- fix dist-hook useless if not building doc and creating error on make
  dist

Better flags for CI

See merge request !65

Sometimes the CI fails on configure, make sure we capture the log file
for those cases.

Recursive makefiles do not propagation automake flags (AM_CFLAGS),
making the proper configuration of the whole build chain more complex
than it needs to be. This patch goes back to a single makefile.am in
src, simplifying the build quite a bit.

One more silent error. ax_pthreads will fail on -Werror, so we still
need to fix that.

Still fails, some issues in configure.ac/Makefile.am

Note that this still fails on make check, some problem with
CPPFLAGS/LDFLAGS

There's an actual bugfix on tilings in there, as well as extra type
mismatches.

Less than perfect types for the most part, plus a few unused variables.

Some string.h definitions only appear if _GNU_SOURCE is defined, which
is done for us in config.h. As usual, only include this in the .c files,
and first in the header.

Vector implementation was lacking some rigor. Note that it is a bit
tricky to use an int for the `na` element and size_t for an index.

Caught by a fun warning about weird function-pointer-to-int conversion.

We've recently received messages indicating that some compiler
environments out there would choke on some of the code. Let's try to
make the code as C99 compliant and as reliable as possible by activating
more warnings and breaking the CI on it.

autoconf macros fail on -Werror -Wall because of unused variable
warnings, so we deactivate those.